search

LibreTexts / ckeditor-binder-plugin

A CKeditor plugin that makes adding binder enabled pre tags easy.
GNU General Public License v3.0
4 stars 2 forks source link

Upgrade to FontAwesome v5 #163

Closed Miniland1333 closed 3 years ago

Miniland1333 commented 3 years ago

Plugin automatically loads FontAwesome v5 scripts unless explicitly disabled with the data-loadFA=false HTML dataset attribute.

The plugin now loads FontAwesome v5 instead of FontAwesome v4. This is expected to be a backwards-compatible update thanks to the v4 shim.

By default, the plugin will auto-load FontAwesome v5. For LibreText's purposes, I have added a dataset flag in which we can optionally disable the autoloading of FontAwesome to prevent conflict with a globally loaded version. <script src="../registerPlugin.min.js" data-loadFA="false"></script>

Closes #157

sandertyu commented 3 years ago

Merging to staging and then I'll test it.