search

LibreTexts / nbgrader-to-jupyterlab

A system for assigning and grading notebooks
https://nbgrader.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Abstract out the ngshare API queries, and add logic to use the right endpoint in a k8s + kube managed JH service environment #3

Closed rkevin-arch closed 4 years ago

rkevin-arch commented 4 years ago

As title. Not tested, and I haven't worked on the nbgrader side, so please look over my code.

rkevin-arch commented 4 years ago

I moved the ignore' statement to be after you get the file size after you pointed it out inexchange.py`. Could you make that change here as well? I still need to test this before approving.

OK, done. I'll also test a bit on my own.

Lawrence37 commented 4 years ago

Is it ok if I make the changes mentioned in my review comments?

rkevin-arch commented 4 years ago

Sure, go ahead.