search

LibreTexts / ngshare

nbgrader sharing service
https://ngshare.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
17 stars 17 forks source link

Uninstalling ngshare #103

Closed celine168 closed 4 years ago

celine168 commented 4 years ago

Have you tried uninstalling ngshare, and are there instructions for it? Is it as simple as helm delete ngshare --purge? One thing I noticed was that ngshare is installed under the kube-system namespace. I don't know whether makes it difficult to uninstall. Might want to consider adding instructions with deploying ngshare on a different namespace like JupyterHub does, but this is up to you guys.

rkevin-arch commented 4 years ago

Yeah, deleting should be that easy (although maybe back up the database first). I'm not sure why it wants to be installed under the kube-system namespace, it should install to whatever namespace you specify (and install to the default namespace, not kube-system, if one isn't specified). This is intended to be installed under the same namespace as JupyterHub, so the hub can talk to it using http://ngshare:8080. If you want it in a separate namespace from JupyterHub, make sure to change the service URL to something like http://ngshare.ngshare-namespace.svc.cluster.local:8080/... in the JupyterHub config.

celine168 commented 4 years ago

I'm not too sure why it didn't install in the default namespace either (it should be the default one if no namespace is specified), but the ngshare-xxx pod is under the kube-system namespace.

This is intended to be installed under the same namespace as JupyterHub

I think this is worth adding to the README; by adding a --namespace option to helm install.

While we are on the similar topic, I think adding the Helm repository is an important step to add to the README as well: helm repo add ngshare https://rkevin-arch.github.io/ngshare-helm-repo/

rkevin-arch commented 4 years ago

The README is sort of out-of-date, I'm working on updating it with more info soon (including how to install https://github.com/lxylxy123456/ngshare_exchange rather than using our fork of nbgrader). I'll look into why helm is messing with kube-system.

celine168 commented 4 years ago

Good to know, thank you! I'm going to open a separate issue about my experience with installing ngshare, if that's ok.

rkevin-arch commented 4 years ago

New documentation has been added to Read the Docs, including an uninstallation guide, so I'm going to close this. Let us know if there are issues during uninstallation.