LibreTexts / ngshare

nbgrader sharing service
https://ngshare.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
17 stars 17 forks source link

Release button dose not work normally (Jupyterhub with dockerspawner ) #169

Open guyq1997 opened 7 months ago

guyq1997 commented 7 months ago

Hello Guys,

i am using ngshare in Jupyterhub with dockerspawner.

Everything goes well if i only use nbgrader.

After i used ngshare, and specify the exchange directory to ngshare API (/services/ngshare). The Release Button does not work.

The Log reported 'Successfully released':

image

But actually there is nothing released, and the Status has not changed at all:

image

But i can see the Assignments are successfully stored in /srv/ngshare of jupyterhub container.

jueren commented 2 months ago

Hello @guyq1997,

we ran into a similar problem and after days(!) of investigation we found out the following:

Have a look here:

Screenshot 2024-08-27 at 18 02 00

Whether it is a pip issue or bug in setuptools, we do not know yet. I hope, the folks at LibreTexts can have a look at it.

I hope, that this information may help you figure out, why you are also unable to do write operations to the sqlite-db (fileupload was working on our side as well)

Cheers

ykazakov commented 1 month ago

The limit < 2.0 of SQLAlchemy was introduced after the release of v0.6.0.

But it is easy to set this limit manually:

pip install ngshare "SQLAlchemy<2.0"
jueren commented 1 month ago

Hi Ykazakov,

thank you for clarifying. that explains the different behaviour.

its very irritating (to say the least) to have an officially released version 0.6.0 that actually does not work. no indication, hints, warnings, logs (while executing the code or in the documentation) ... failing quietly is considered very bad practice. please release the fix of this particular severe bug as a new version as soon as possible.

and no: one does NOT want to install specific version of a subpackage when adding a dependency. we want to add a sound and consistent package installed in a specific version.

Cheers

moorepants commented 1 month ago

@jueren Your last message is not appreciated and nor does it invoke any cheer. What is irritating are comments like yours made to people that provide you software for free. Maybe you are unfamiliar with how open software is developed. Our OSS license precisely specifies this:

THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.

If you don't like how it works, then you are welcome to contribute fixes or to fork it and use it as you like.