search

LibriVox / librivox-catalog

LibriVox catalog and reader workflow application
https://librivox.org
MIT License
37 stars 17 forks source link

Remove unused variables from advanced search #157

Closed garethsime closed 1 year ago

garethsime commented 1 year ago

Fixes #155.

Calling $this->_get_projects_by_section_author($params['author']); without an author ID is really expensive, and we just throw the result away anyway. I also removed a few other unused variables while I was there, though the performance impact of those was negligible.

This should make searching by reader without an author much faster.

notartom commented 1 year ago

This code predates me by a long time, and the only person who understood is has long since moved on to other things, but both code inspection and testing bear this out - it's unused, and it makes search by reader much faster. Thanks!