search

LibriVox / librivox-catalog

LibriVox catalog and reader workflow application
https://librivox.org
MIT License
37 stars 17 forks source link

Reader page access ignores query string #158

Closed twinkietoes-on closed 9 months ago

twinkietoes-on commented 1 year ago

(I hope this is clear enough. It's just beyond my thorough understanding. I'm copy/pasting.)

Any access to the reader page (eg, https://librivox.org/reader/8463) clobbers the querystring. For example: https://librivox.org/reader/8463?primary_key=8463&search_category=reader&search_page=4&search_form=get_results

The query includes the parameter "search_page=4", so the expected behavior would be to display results starting on page 4. Instead the search script ignores the entire querystring and displays the first page of results.

https://forum.librivox.org/viewtopic.php?p=2156227#p2156227

redrun45 commented 9 months ago

Thanks to garethsime (thank you!), we no longer lose the page on reader searches. We might close this as fixed, since I don't see anything else there to be broken by the clobbering.

notartom commented 9 months ago

So as @garethsime said in https://github.com/LibriVox/librivox-catalog/pull/167, his patch fixes Author, Group, and Reader pages. Are there other pages where the query string is being ignored that haven't been fixed by his patch?

redrun45 commented 9 months ago

Not that I'm aware of. I think if we run into any more such issues, we can file them separately.