search

LibriVox / librivox-catalog

LibriVox catalog and reader workflow application
https://librivox.org
MIT License
37 stars 17 forks source link

fix/#146 better error messages in uploader #175

Closed hamidsafdari closed 9 months ago

hamidsafdari commented 10 months ago

Detect if message is originated using AJAX and send appropriate response.

notartom commented 9 months ago

Oh, and if you tag the issue in your commit message, something like Closes issue #175, the issue will auto-close when this merges.

hamidsafdari commented 9 months ago

I'm sorry, but I honestly felt discouraged by the response time on PRs and removed the project environment. I've also made other PRs #174, #176 and one in librivox-ansible. You have requested for change on those PRs too, and I updated my code, but there was no response after that.

notartom commented 9 months ago

I get it. I've tried to set expectations that LibriVox reviews, especially when the PR is very big, seldom have quick turnaround times because other things in life take priority for me. I'll update this PR and merge it. If you're really no longer interested in working on the other PRs, I'll have to abandon them, as they will require a lot of review effort, and I don't want to put in the time if you've moved on to bigger and better things.

Edit: I should add, I'm not the original author of our PHP or JS code. I can grok PHP pretty well because my day job is Python, but my JS knowledge beyond the basics is pretty non-existent. This is all code I inherited when I became the volunteer IT guy for LV. So reviewing PHP changes is relatively quick, reviewing JS changes takes more effort. I can try to clarify all that in the CONTRIBUTING.md file.

notartom commented 9 months ago

Merged as https://github.com/LibriVox/librivox-catalog/commit/1c0a92179477e3589939da2cbd715f5c1942ff12