redrun45
commented
6 months ago One way to intro the Archive search link:
And another way:
And a mooted combination:
Closed peterjdann closed 6 months ago
redrun45
commented
6 months ago One way to intro the Archive search link:
And another way:
And a mooted combination:
peterjdann
commented
6 months ago Not sure that it’s my place to be commenting at all (this is my first ever contribution of any kind to an open source project) but this latest suggestion sure looks good to me.
On 11 Mar 2024, at 1:08 pm, redrun45 @.***> wrote:
@redrun45 commented on this pull request.
In application/views/catalog/partials/advanced_search.php https://github.com/LibriVox/librivox-catalog/pull/204#discussion_r1519065757:
@@ -100,10 +100,9 @@
I don't know what the preferences are for keeping commit history "clean", but at any rate, here's https://github.com/LibriVox/librivox-catalog/pull/206 the version that admins we'd like to go with.
— Reply to this email directly, view it on GitHub https://github.com/LibriVox/librivox-catalog/pull/204#discussion_r1519065757, or unsubscribe https://github.com/notifications/unsubscribe-auth/APUJ53EKA6GLYH5P75GOGC3YXUG2VAVCNFSM6AAAAABEOZGMVSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRWHAYDOMRVGU. You are receiving this because you authored the thread.
notartom
commented
6 months ago
This view change adds some text beneath the Advanced Search Submit button. The general idea was first discussed here: https://forum.librivox.org/viewtopic.php?t=101695&start=90 (see for example my post in this thread dated 3 March,2024, 9:32 am). On 6 March redrun appeared to indicate that some change of this sort should move forward. I have slightly altered the text from what I originally suggested.