search

LibtraceTeam / libtrace

C Library for working with network packet traces
GNU Lesser General Public License v3.0
158 stars 50 forks source link

A resource leak #200

Closed ryancaicse closed 5 months ago

ryancaicse commented 2 years ago

fopen should be closed in the method misc_report? https://github.com/LibtraceTeam/libtrace/blob/d827850a048405324dcdb39feeee8b3dd01378a6/tools/tracereport/misc_report.c#L100-L115

ryancaicse commented 2 years ago

Could you take a look? Many thanks. @salcock

salcock commented 2 years ago

Yes, I think you're right -- not closing probably won't have any major impact as the OS will clean up when the process exits, but it is still a good spot on your part ;)

salcock commented 5 months ago

Fixed in the develop branch and will be included in the next release.