Libvisual / libvisual

Libvisual Audio Visualization
http://libvisual.org/
81 stars 31 forks source link

Core (Build): Get MSVC to use correct values for the __cplusplus define #269

Closed kaixiong closed 1 year ago

kaixiong commented 1 year ago

Rant: As usual, Microsoft does its own thing.

References:

hartwork commented 1 year ago

@kaixiong PS: On a side note we're saying goodbye to Visual Studio <2017 (at least in part) here. Fine in my book, but important to know.

kaixiong commented 1 year ago

@hartwork I ported Libvisual to Win32 (writing the WaveIn input in the process) and have never tried to compile it on MSVC. Maybe I should try one of these days and see where the gaps are. Interestingly enough, MSVC is now ahead of both GCC and Clang in terms of the latest C++ standard support.

hartwork commented 1 year ago

@kaixiong we can make the CI cover MSVC at some point.

kaixiong commented 1 year ago

@kaixiong PS: On a side note we're saying goodbye to Visual Studio <2017 (at least in part) here. Fine in my book, but important to know.

@hartwork We already are, master requires C++20 to build.

hartwork commented 1 year ago

@kaixiong I guess you're right — https://en.cppreference.com/w/cpp/compiler_support#cpp20