libvisual-plugins (lcdcontrol): Address Clang 18 warning `-Wvla-cxx-extension` to fix CI

Libvisual / libvisual

Libvisual Audio Visualization

http://libvisual.org/

82 stars 31 forks source link

libvisual-plugins (lcdcontrol): Address Clang 18 warning `-Wvla-cxx-extension` to fix CI #325

Closed hartwork closed 8 months ago

hartwork commented 8 months ago

Symptom was:

[..]/libvisual-plugins/plugins/actor/lcdcontrol/GenericSerial.cpp:141:15: error: variable length arrays in C++ are a Clang extension [-Werror,-Wvla-cxx-extension]
  141 |     char buff[len + 1];
      |               ^~~~~~~

.. plus the same a few times more.

kaixiong commented 8 months ago

Ideally we should use std::vector for this but this is okay for now.

hartwork commented 8 months ago

@kaixiong thanks!