[Pf2e] Effect Icons Off Screen

abstract commented 1 month ago

I'm having an issue in Pathfinder 2e when using this module. The images below show exactly what the issue is. The first image shows the buff icons/text going off the top of the screen with TotM-Manager active and the second image shows what it should look like with TotM-Manager deactivated.

Both images show that TotM-Manager is the only difference between the displays.

With TotM-Manager active

With TotM-Manager deactivated

mclearc commented 1 month ago

Can you tell me what versions you have of foundry, pathfinder 2, and TotMM plus its dependencies?

abstract commented 1 month ago

Foundry Virtual Tabletop v12.330 Pathfinder Second Edition v6.2.1 TotMM v0.8.5 libWrapper v1.12.15.0 Tagger v1.5.1 Token Magic FX v0.6.8

mclearc commented 1 month ago

Thanks -- I'll look into this tonight if I can. v12 has been causing more issues in various game systems than I expected.

abstract commented 1 month ago

I believe I've found the issue. I figured it was a CSS conflict, so I compared TotMM's styles to Pathfinder Second Edition's and I found a match. I deleted the conflicting style locally, and it fixed the issue on my machine.

The CSS conflict is the class .effect-item which is present in both.

In your CSS, it is on line 328 here: https://github.com/LichFactory-Games/TotM-Manager/blob/main/styles/totmm.css#L328

.effect-item {
    display: flex;
    align-items: center;
    padding: 5px;
}

In the PF2e CSS, it is in _effects-panel.scss line 7 here: https://github.com/foundryvtt/pf2e/blob/master/src/styles/system/_effects-panel.scss#L7

    .effect-item {
        display: flex;
        justify-content: end;
        height: 52px;

You will just need to change the name of your CSS class to something else.

mclearc commented 1 month ago

I properly namespaced all html classes. Let me know if you still see issues.

LichFactory-Games / TotM-Manager

[Pf2e] Effect Icons Off Screen #7