Lichess4545 / Chesster

Chesster Moderator Bot for Lichess45+45
28 stars 22 forks source link

Fixes #357 For real this time - bad property check #407

Closed mathgeek closed 2 years ago

mathgeek commented 2 years ago

These functions exist but were unused before my (relatively new) code to detect alts was added. white_team is the property on the response object from Heltour, but whiteTeam is how it should exist on the TeamPairing object

mathgeek commented 2 years ago

This check was failing at https://github.com/Lichess4545/Chesster/blob/main/src/league.ts#L293 and therefore not set at https://github.com/Lichess4545/Chesster/blob/main/src/league.ts#L526

lakinwecker commented 2 years ago

I'm confused by your comment about these changes. The changes may very well work, but what you're describing to me is unclear.

lakinwecker commented 2 years ago

Made a ticket for fixing the lack of consistency: https://github.com/Lichess4545/Chesster/issues/408