search

Lichess4545 / heltour

Chess tournament management software for the Lichess4545 league
https://www.lichess4545.com/
MIT License
46 stars 38 forks source link

435 do not start alt search for late opponent assignment #452

Closed hopffgam closed 2 years ago

hopffgam commented 2 years ago

fixes #435 introduce a timestamp for when a player was changed last time on a pairing. Do not trigger unresponsive workflows if a player change was registered after the round start and the pairing is for the team league, as that means that an alternate was put on the pairing late and the opponent in fact did not have 24 hrs to respond.

lakinwecker commented 2 years ago

I'm going to just describe my understanding of this change, to make sure that I understand it:

  1. The previous check (just white_unavail or black_unavail) worked when the 24 hours contact period was over and an alternate had not yet been assigned.
  2. This change is to address the situation where an alternate is assigned at hour 23 and the player that was waiting for a pairing only has an hour to respond?
lakinwecker commented 2 years ago

Just minor things with this one. But otherwise looks like it should work as intended.

lakinwecker commented 2 years ago

Looks good. I'll merge and deploy both of these in the upcoming days