Lichess4545 / heltour

Chess tournament management software for the Lichess4545 league
https://www.lichess4545.com/
MIT License
46 stars 38 forks source link

validate pending registrations daily #507

Closed glbert-does closed 1 year ago

glbert-does commented 1 year ago

once a day, validate pending registrations. this closes #200, in a manner of speaking. instead of updating the rating and only then triggering validation on players with established rating, it simply triggers validation of all pending registrations. i am not certain how big the difference is, since as far as i can tell, a validation will force an update of the rating anyway.

running this every second day would be perfectly ok as well.

glbert-does commented 1 year ago

i did some tests – but they were probably not as exhaustive as they should be. i basically set it to run every minute and added one reg of every useful type i could think of, checking that only regs were revalidated where it is useful, and that validated regs changed as a appropriate. so, in essence i tested it on maybe 20 regs.

i don't think i would feel comfortable to merge right now myself; i can run more tests in about a week or two. if someone else can do more tests before that, that would of course be fine for me. it would probably be helpful for mods to have this working during pre-season.