Position Z not taken into account in the converter

Lichtblick-Suite / asam-osi-converter

Lichtblick extension which visualizes data following the standard of the ASAM Open Simulation Interface (ASAM OSI) using the native 3D panel of Lichtblick.

MIT License

2 stars 2 forks source link

Position Z not taken into account in the converter #12

Open MattPaquet opened 1 week ago

MattPaquet commented 1 week ago

In the function objectToCubePrimitive (https://github.com/Lichtblick-Suite/asam-osi-converter/tree/main/common/utils/marker.ts) :

The z value is not calculated from actual object position : position: { x: processed_x, y: processed_y, z: height / 2.0,

So two object on different Z values will appears next to each other even if they are not.

jdsika commented 1 week ago

Alright, I think we have that issue detected as well. I am planning to priorize this in the next weeks.

jdsika commented 6 days ago

@MattPaquet FYI The moment you encounter a problem and you know already the solution feel free to add your own PR