Lichtwerkstatt / XRTL_SPA

Single Page Application for XRTL Remote Lab
https://xrtl.uni-jena.de/
GNU Affero General Public License v3.0
2 stars 3 forks source link

Secondary Beamsplitter should move in virtual model #109

Closed jkbeetle closed 1 year ago

jkbeetle commented 1 year ago

The virtual model is intended to be a digital twin, and therefor should represent the real experiment as close as possible. So the rotational position of the secondary beamsplitter has to rotate up and down on user input, resp. the state.

Accordingly the beam-visualization should change as well depending on the status of the secondary beamsplitter and should not be selectable by user input.

Implementation:

LuponasAtWork commented 1 year ago

point 1 and 2 of implementation are already done. Currently, I can not access the status of the components in the experiment model ("mesh file"). @Claralein any idea how to address that?

Claralein commented 1 year ago

The virtual model is intended to be a digital twin, and therefor should represent the real experiment as close as possible. So the rotational position of the secondary beamsplitter has to rotate up and down on user input, resp. the state.

Accordingly the beam-visualization should change as well depending on the status of the secondary beamsplitter and should not be selectable by user input.

Implementation:

Claralein commented 1 year ago

@LuponasAtWork You could write a new function in the AppContext that changes the value of the varaibale in the AppContext based on the status of the beamSplitter.

Claralein commented 1 year ago

@LuponasAtWork

I have prepared everything for the beamsplitter animation. There is a variable (beamSplitterState), which is reset with change of the beam splitter (true... in the beam path, false... not in the beam path).

LuponasAtWork commented 1 year ago

I did my part (besides the bonus). There are now some unused vars and I'm not sure if they might be still needed, so I left them in the NavBar.js for now.

Claralein commented 1 year ago

@LuponasAtWork Can this issue be closed?

LuponasAtWork commented 1 year ago

I'm afraid so. I don't feel like digging into the huge field of animation with three.js right now.