Lickability / PinpointKit

Send better feedback
MIT License
1.13k stars 79 forks source link

Swift 3.0 Maintenance #196

Closed mliberatore closed 7 years ago

mliberatore commented 7 years ago

What it Does

Maintenance work for Xcode 8.2.

screen shot 2017-01-13 at 12 40 44 pm

How to Test

  1. Create a new Xcode project (Single View Application)
  2. Run pod init
  3. Run open Podfile and add pod 'PinpointKit', :git => 'https://github.com/Lickability/PinpointKit.git', :branch => 'swift-3.0-maintenance' to your target.
  4. Run pod install
  5. Close the project and open the newly created workspace
  6. Choose "Later" when prompted to convert to current Swift syntax
  7. Build without any warnings / errors
  8. Open ViewController.swift and replace the contents with the snippet at the end of this series of steps.
  9. Build and Run, verifying that PinpointKit’s UI appears
import UIKit
import PinpointKit

class ViewController: UIViewController {

    let pinpointKit = PinpointKit(feedbackRecipients: ["something@example.com"])

    override func viewDidAppear(_ animated: Bool) {
        super.viewDidAppear(true)

        pinpointKit.show(from: self)
    }
}
bcapps commented 7 years ago

Everything here looks good 👍 But I'm still seeing the same white blinking issue in this new project that I saw in #195, which points to it probably being a pre-existing issue.