search

Lickability / PinpointKit

Send better feedback
MIT License
1.13k stars 79 forks source link

Remove Swiftlint As Framework / Add As Pod #232

Closed Twigz closed 7 years ago

Twigz commented 7 years ago

Closes #225

What It Does

Switches to using Swiftlint as a pod.

How to Test

Make sure the project runs and there are no warnings. Conversely, make sure Swiftlint warnings are appropriately generated for both the example and the framework.

mliberatore commented 7 years ago

✅ Make sure the project runs and there are no warnings. ✅ Conversely, make sure Swiftlint warnings are appropriately generated for both the example and the framework.

Looks good and works well. Two small things to mention before merging.

  1. Should this be pointed at develop?
  2. Currently, building just the framework in PinpointKit.xcodeproj (i.e. not the example workspace) doesn’t cause swiftlint warnings to emit, and I believe that’s intended / unnecessary to add, but I wanted to double check before approving.

Edit