search

Lickability / PinpointKit

Send better feedback
MIT License
1.13k stars 79 forks source link

Fixes Custom Fonts Not Appearing When Installing PinpointKit Manually #248

Closed mliberatore closed 6 years ago

mliberatore commented 6 years ago

Closes #247

What It Does

Adds fonts to the PinpointKit Xcode Project’s Copy Bundle Resources Phase to fix the fonts not appearing when manually installing the framework.

How to Test

Follow the steps for installing via CocoaPods, Carthage, and Manually, but replace versions or branch names like those below. Smoke test the framework, making sure the custom fonts are used, and that there are no console logs about resources, or anything else you could think of to indicate that this change has unintended side-effects.

CocoaPods

pod 'PinpointKit', :git => 'https://github.com/Lickability/PinpointKit.git', :branch => 'add-fonts-to-pinpoint-kit-target'

Carthage

github "Lickability/PinpointKit" "add-fonts-to-pinpoint-kit-target"

Manually

git init
git submodule add -b add-fonts-to-pinpoint-kit-target https://github.com/Lickability/PinpointKit.git

Notes

N/A