Upgrades project to Xcode 10 and Swift 4.2 - Githubissues

Lickability / PinpointKit

Send better feedback

MIT License

1.13k stars 79 forks source link

Upgrades project to Xcode 10 and Swift 4.2 #252

Closed jilliangmeehan closed 6 years ago

jilliangmeehan commented 6 years ago

Progress on #251

What It Does

Ran the Swift migrator on the example app, making necessary changes where Apple's suggested changes weren't great
Opened PinpointKit.xcodeproj and resolved Swift version errors
Updated the README to reflect new Xcode and Swift requirements
Changed the .swift-version to 4.2 for CocoaPods

How to Test

Smoke test the example app in Xcode 10, ensuring that basic features still work.

Notes

We still want to do more testing, and test all 3 install methods before closing the issue.