Liftric / DIKit

Dependency Injection Framework for Swift, inspired by KOIN.

MIT License

102 stars 17 forks source link

Swift Lint #26

Closed JZDesign closed 5 years ago

JZDesign commented 5 years ago

SwiftLint

Adds swift lint, ran autocorrect, disabled force_cast in singular file disabled nesting in singular file

benjohnde commented 5 years ago

Oh my gosh, I am super happy about your contribution. This project started very small, we are using it in production, and I am still having plans to improve it.

benjohnde commented 5 years ago

I am going to review it properly tomorrow morning! Huge thanks to you for the contribution, yeay still happy. Cheers!

JZDesign commented 5 years ago

Happy to help! I added an auto-correct script to your build phases section of the project. This can some times make XCode act funny if you build and then make changes as it's building. What happens is SwiftLint tries to edit and save the file when you are so the IDE gets confused. Aside from that, SwiftLint is awesome

benjohnde commented 5 years ago

Just two small things for the future (I am going to merge this anyway):

we use a little different commit message convention, so for the future CONTRIBUTING.md.
you made two changes in one commit: actual swiftlint implementation and some small structural code changes, which I am completely fine with. next time, please commit two times. The latter one was a pretty small change but still I would love retain a nice structure.

Thanks again so very much for the help!

JZDesign commented 5 years ago

Awesome! Sorry I’ll pay a little more attention next time. I should have committed the addition to swiftlint then ran it and stashed the autocorrect changes