search

LightBitsLabs / los-csi

Lightbits LightOS CSI Plugin
Other
0 stars 2 forks source link

Fix argument passed to ListProcMounts #34

Closed scarlet-storm closed 9 months ago

scarlet-storm commented 9 months ago

Fixes #33

muliby-lb commented 9 months ago

Thanks @scarlet-storm ! Seems like a simple and obvious fix, but I wonder whey we've never hit this before. CC @yogev-lb @dror-lb @rahman-lb

robot-lb commented 9 months ago

Can one of the admins verify this patch?

yogev-lb commented 9 months ago

@muliby-lb The fix looks legit and indeed some time ago @lev-lb raised this concern but it was not addressed at the time sadly.

The reason we didn't see it till now (or saw it once in a long time) is that this flow would happen only when kubelet will call the plugin's NodePublishVolume twice (when the volume is already mounted).

This scenario happened due to kubelet restarted which is not a common thing in a running system.

We understand the fix and the mistake of invoking this function with the wrong parameter and we can say that this should a. solve the issue, and b. not raise any other issue.

muliby-lb commented 9 months ago

Thanks @yogev-lb, makes sense. Are you running PR check on this via lb-csi and will update here when it passes? We want to get this merged and cut out a new CSI plugin release ASAP.