LightBitsLabs / los-csi

Lightbits LightOS CSI Plugin
Other
0 stars 2 forks source link

Dockerfile: Fix XFS fs type regression #52

Open husam-lb opened 2 months ago

husam-lb commented 2 months ago

XFS has a habit of being incompatible with userspace when it comes to default fs options. This time with fs options: bigtime=1 inobtcount=1 are enabled by default in new xfsprogs and unknown in older xfs, which creates the following errors: XFS (nvme0n1): Filesystem cannot be safely mounted by this kernel. XFS (nvme0n1): Superblock has unknown read-only compatible features (0x8) enabled.

Use fixed xfsprogs version 5.12.0-r0 from apline:3.14 to avoid this issue. newer implementations will not have these features enabled, and once mountutils fixes the incompatibility, we can drop this.

Summary by CodeRabbit

coderabbitai[bot] commented 2 months ago
Walkthrough ## Walkthrough The recent changes focus on enhancing the reliability and consistency of package installations in the deployment process. By specifying a particular repository for Alpine Linux version 3.14 and explicitly defining versions for certain packages, the updates aim to improve version control and reduce potential compatibility issues during deployment. ## Changes | Files | Change Summary | |---------------------------|---------------------------------------------------------------------------------------------------------| | deploy/Dockerfile | Updated package installation command to specify a repository for Alpine 3.14; defined versions for `xfsprogs` and `xfsprogs-extra` as `5.12.0-r0`. No other changes were made. |

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): > :bangbang: **IMPORTANT** > Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged. - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
sonarcloud[bot] commented 2 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

husam-lb commented 2 months ago

alpine v3.14 repos are the latest to support xfsprogs-5.12.0-r0 which in turn needed to support xfs volumes

majst01 commented 2 months ago

o support xfsprogs-5.12.0-r0

Still do not understand why newer xfsprogs break volume creation, i really cant imagine that they break compatibility.

By any chance, on which kernel version does this happen ?

husam-lb commented 2 months ago

o support xfsprogs-5.12.0-r0

Still do not understand why newer xfsprogs break volume creation, i really cant imagine that they break compatibility.

By any chance, on which kernel version does this happen ?

I think it because of using old kernel alpine 3.19 has kernel 5.15.0-91-generic

majst01 commented 2 months ago

o support xfsprogs-5.12.0-r0

Still do not understand why newer xfsprogs break volume creation, i really cant imagine that they break compatibility. By any chance, on which kernel version does this happen ?

I think it because of using old kernel alpine 3.19 has kernel 5.15.0-91-generic

the container image does not come with a kernel, i was asking which kernel the worker node has where this error occurs ?

husam-lb commented 2 months ago

it's 5.15.0-91-generic

majst01 commented 2 months ago

it's 5.15.0-91-generic

So you have alpine worker nodes ?

rahman-lb commented 2 months ago

@majst01 Node host OS is Ubuntu 22.04 but the POD's container image is alpine 3.19.x, but i'm guessing this should be a problem on any setup has this version.

majst01 commented 2 months ago

@majst01 Node host OS is Ubuntu 22.04 but the POD's container image is alpine 3.19.x, but i'm guessing this should be a problem on any setup has this version.

The OS in the container is not relevant, the xfs-progs are talking to the host kernel to create the Filesystem. I doubt that there is a incompatibility between certain xfs-progs and a ubuntu kernel

husam-lb commented 2 months ago

Things look better with kernel 6.8.0-36-generic of ubnutu 24.4 I it was ok, I will close this pr