search

LightBitsLabs / los-csi

Lightbits LightOS CSI Plugin
Other
0 stars 2 forks source link

get rid of the direct k8s.io/kubernetes dependency #6

Closed majst01 closed 2 years ago

majst01 commented 2 years ago

Depending on k8s.io/kubernetes is strongly discouraged because it introduces a hell when updating.

I simply copied the bare implementation of the fs.Info found in kubernetes upstream therefore.

AKA: it is better to copy 100lines of code than introduce a dependency to millions of lines.

muliby-lb commented 2 years ago

Thanks, @majst01 ! CC @lev-lb @yogev-lb FYI @sagi-lb

majst01 commented 2 years ago

I will simplify even further, wait for it before merging

majst01 commented 2 years ago

Now its ready for review and eventually merge.

majst01 commented 2 years ago

closed in favour of #8