read:packages error toast when using oauth login

[TheFern2]

Getting an error for package read permission. I didn't see this on the permissions scopes, so probably just need to be added so user can authorize it as a scope.

[LightDestory]

The permission is android.permission.READ_LOGS?

[TheFern2]

Sorry should have more clear, I believe this is not on the oauth scopes.

https://docs.github.com/en/developers/apps/building-oauth-apps/scopes-for-oauth-apps

Getting a read:packages error on the latest release.

[LightDestory]

Oauth can't access packages listing.

For the best experience use a Personal Access Token (it is displayed as recommended)

Il Mar 19 Apr 2022, 19:11 Fernando B @.***> ha scritto:

Sorry should have more clear, I believe this is not on the oauth scopes.

https://docs.github.com/en/developers/apps/building-oauth-apps/scopes-for-oauth-apps

Getting a read:packages error on the latest release.

— Reply to this email directly, view it on GitHub https://github.com/LightDestory/FastHub-RE/issues/36#issuecomment-1102891550, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKNR3VRYDFYTSM7EI5WI7DVF3SMPANCNFSM5TUML7LQ . You are receiving this because you commented.Message ID: @.***>

[TheFern2]

I thought it wasn't being requested. I see read:packages on oauth permissions. Should work with oauth imo, though I could be wrong.

[LightDestory]

Hmm I will check, maybe I forgot to update the scope string.

I don't use oauth login due to Organizzation issues, oauth application needs to request permission per organisation. Using a Token makes everything easier xD

Thanks for the feedback.

Package implementation is still very basic because we have a problem with requery.

This project is very old and we must find a way to get it working on newer dependencies.

Il Mar 19 Apr 2022, 22:26 Fernando B @.***> ha scritto:

I thought it wasn't being requested. I see read:packages on oauth permissions. Should work with oauth imo, though I could be wrong.

— Reply to this email directly, view it on GitHub https://github.com/LightDestory/FastHub-RE/issues/36#issuecomment-1103106461, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKNR3RYMLMJ76M746R6ASLVF4JGFANCNFSM5TUML7LQ . You are receiving this because you commented.Message ID: @.***>

[TheFern2]

Yeah no worries don't mind me I just report things to make things better in the future. I don't care much for packages tbh so this issue isn't much about packages but more about the error toast when using oauth (will rename issue), but anytime I go to a repo I get the read:packages error toast. I do agree tokens make it easier. I will switch to it for now to avoid seeing the toast.

[LightDestory]

We can close this thanks to 0842881.

Re-open if you find any issues.

To test out right away the changes you can wait for the GitHub Action and download the artifact from there. Be aware that github action offers debug builds that use debugging keys. So you will be prompt to give permission to the "FastHub Demo" OAuth application.

This fix will be on 4.7.8, when released.

[TheFern2]

Thanks for the fix! I'll test it out asap.