LightDestory / FastHub-RE

Revival Attempt for FastHub the ultimate GitHub client for Android.
GNU General Public License v3.0
248 stars 17 forks source link

Bug: themes don't apply correctly #41

Open Efreak opened 2 years ago

Efreak commented 2 years ago

When applying a dark theme, the theme doesn't apply properly to the background of the main repo list or to various action/title bars. For the most part, the title bars just don't match, so it's low priority, but if you're trying to browse decent activity, it's quite difficult.

I'm adding screenshots here Drawer open on main page: ![Drawer open](https://gist.github.com/Efreak/34309d184446f07e90edf78458d59345/raw/709704f576f175e46ec7cd37a07bfeebd7441549/Screenshot_20220522-144406_FastHub-RE.png) Main issues page: ![Main issues page](https://gist.github.com/Efreak/34309d184446f07e90edf78458d59345/raw/709704f576f175e46ec7cd37a07bfeebd7441549/Screenshot_20220522-144925_FastHub-RE.png) Main page, pull requests ![Pull requests](https://gist.github.com/Efreak/34309d184446f07e90edf78458d59345/raw/709704f576f175e46ec7cd37a07bfeebd7441549/Screenshot_20220522-144932_FastHub-RE.png) Typing in an issue: ![typing issue](https://gist.github.com/Efreak/34309d184446f07e90edf78458d59345/raw/709704f576f175e46ec7cd37a07bfeebd7441549/Screenshot_20220522-144835_FastHub-RE.png) Creating an issue: ![Creating an issue](https://gist.github.com/Efreak/34309d184446f07e90edf78458d59345/raw/709704f576f175e46ec7cd37a07bfeebd7441549/Screenshot_20220522-144854_FastHub-RE.png) I notice that the action/title bar in the about page works just fine: ![About](https://gist.github.com/Efreak/34309d184446f07e90edf78458d59345/raw/709704f576f175e46ec7cd37a07bfeebd7441549/Screenshot_20220522-145132_FastHub-RE.png)

Off-topic note: There should probably be a second version of the below text that includes the fasthub version number as well as some device info; this would probably help with reporting bugs, both to fasthub and other projects. I'm using Android 12 on a Tab S6, using the latest version of Fasthub-RE (I just installed the latest version from this repo)

Sent from my Galaxy Tab S6 using FastHub-RE

LightDestory commented 2 years ago

Please check if the original FastHub is affected by this issue too, so we can classify as bug or regression.

On Mon, May 23, 2022, 00:09 Efreak @.***> wrote:

When applying a dark theme, the theme doesn't apply properly to the background of the main repo list or to various action/title bars. For the most part, the title bars just don't match, so it's low priority, but if you're trying to browse decent activity, it's quite difficult. I'm adding screenshots here

Drawer open on main page:

[image: Drawer open] https://camo.githubusercontent.com/08b9c634599edb3a00e8362f7ffe4d2a8f01cab158c6c23a4f4eba0c7220460c/68747470733a2f2f676973742e6769746875622e636f6d2f45667265616b2f33343330396431383434343666303765393065646637383435386435393334352f7261772f373039373034663537366631373565343665633763643337613037626665656264373434313534392f53637265656e73686f745f32303232303532322d3134343430365f466173744875622d52452e706e67

Main issues page:

[image: Main issues page] https://camo.githubusercontent.com/c812956f37204d6c2ebf4a6e1a5e508597115cdfd39d51a58251b9e2b17aff33/68747470733a2f2f676973742e6769746875622e636f6d2f45667265616b2f33343330396431383434343666303765393065646637383435386435393334352f7261772f373039373034663537366631373565343665633763643337613037626665656264373434313534392f53637265656e73686f745f32303232303532322d3134343932355f466173744875622d52452e706e67

Main page, pull requests

[image: Pull requests] https://camo.githubusercontent.com/70885ff711c5038e6303f8791f5d4b124b27e9b86c6a9497781ef3883e2ce52f/68747470733a2f2f676973742e6769746875622e636f6d2f45667265616b2f33343330396431383434343666303765393065646637383435386435393334352f7261772f373039373034663537366631373565343665633763643337613037626665656264373434313534392f53637265656e73686f745f32303232303532322d3134343933325f466173744875622d52452e706e67

Typing in an issue:

[image: typing issue] https://camo.githubusercontent.com/2dff7ef7276f30f92c2fcb58ef25155f371a7c9d83d5d11d9e14c709b3288a57/68747470733a2f2f676973742e6769746875622e636f6d2f45667265616b2f33343330396431383434343666303765393065646637383435386435393334352f7261772f373039373034663537366631373565343665633763643337613037626665656264373434313534392f53637265656e73686f745f32303232303532322d3134343833355f466173744875622d52452e706e67

Creating an issue:

[image: Creating an issue] https://camo.githubusercontent.com/171ba605effa8f295dd41955894825d3d4d7b939f325e243b1492b4a57a10fda/68747470733a2f2f676973742e6769746875622e636f6d2f45667265616b2f33343330396431383434343666303765393065646637383435386435393334352f7261772f373039373034663537366631373565343665633763643337613037626665656264373434313534392f53637265656e73686f745f32303232303532322d3134343835345f466173744875622d52452e706e67

I notice that the action/title bar in the about page works just fine:

[image: About] https://camo.githubusercontent.com/f660d1b5fcf3b2cca0171ee74249f9950faeb4f9414baaec986738691a472d12/68747470733a2f2f676973742e6769746875622e636f6d2f45667265616b2f33343330396431383434343666303765393065646637383435386435393334352f7261772f373039373034663537366631373565343665633763643337613037626665656264373434313534392f53637265656e73686f745f32303232303532322d3134353133325f466173744875622d52452e706e67

Off-topic note: There should probably be a second version of the below text that includes the fasthub version number as well as some device info; this would probably help with reporting bugs, both to fasthub and other projects. I'm using Android 12 on a Tab S6, using the latest version of Fasthub-RE (I just installed the latest version from this repo)

Sent from my Galaxy Tab S6 using FastHub-RE https://github.com/LightDestory/FastHub-RE/

— Reply to this email directly, view it on GitHub https://github.com/LightDestory/FastHub-RE/issues/41, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABKNR3W5DP4QWVG6XFUWKLLVLKV7XANCNFSM5WT74KZA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Efreak commented 2 years ago

Fasthub libre is unaffected, as is original fasthub. I should note that fasthub is no longer available on Google Play, so it might be worth including an original fasthub apk somewhere.

LightDestory commented 2 years ago

Original fasthub apk can be easily downloaded from the repository:https://github.com/k0shk0sh/FastHub/releases

Efreak commented 2 years ago

Not anymore, unfortunately. I've added the apks to my fdroid repo.

AutumnRivers commented 2 years ago

Can confirm I'm having this issue as well, but do not have this issue on the latest version of FastHub linked above

HampusMat commented 2 years ago

I have the same problem. I'm using LineageOS 18.1 (Android 11) Screenshot_20221116-231958_FastHub-RE