LightForm-group / Diffraction-postprocessing

A repository for post-processing matflow-damask simulations using python functions to calculate and plot stress, strain, etc. in a easy-to-follow jupyter notebook.
MIT License
4 stars 0 forks source link

Example notebook: are the examples intended to be independent? #5

Closed gcapes closed 1 year ago

gcapes commented 1 year ago

There is some duplication of python imports e.g. numpy and matplotlib

Perhaps all the imports could go at the top, or the examples could be split into separate notebooks?

Similarly this variable is assigned in four different examples: ve_response = workflow.tasks.simulate_volume_element_loading.elements[0].outputs.volume_element_response

Gbowker commented 1 year ago

commit bdec57e removes duplicate definitions of ve_response variable.