LightGuard / asciidoc-splitter

A splitter utility for helping create modular docs from chapter files.
BSD 2-Clause "Simplified" License
8 stars 8 forks source link

Splitter should add extra line break before imports are supplied #94

Closed wtrocki closed 2 years ago

wtrocki commented 2 years ago

Without extra enter in the content splitter will produce content in the same line that breaks ascidoctor:

Screenshot 2021-10-01 at 16 44 29

Examples of changes that were needed:

https://github.com/redhat-developer/app-services-guides/pull/324/commits/ccc288b66885c8ccb90d63feae51659344c7e83c

wtrocki commented 2 years ago

@LightGuard Thank you so much

wtrocki commented 2 years ago

CC @pmuir - we can create issue to update jar :)

pmuir commented 2 years ago

@LightGuard are you publishing to a maven repo now? If so, we could switch our builds to pull from maven, rather than store in git.

LightGuard commented 2 years ago

I should be, I'll cut a release today.

pmuir commented 2 years ago

And when you do, remind us of the maven coordinates ;-)

LightGuard commented 2 years ago

@pmuir https://github.com/LightGuard/asciidoc-splitter/packages/694327

pmuir commented 2 years ago

I tried to do the update but I'm now getting other errors about unclosed endif - see https://github.com/redhat-developer/app-services-guides/pull/361 and https://github.com/redhat-developer/app-services-guides/runs/4020939353?check_suite_focus=true

pmuir commented 2 years ago

BTW we can't easily use the github maven repo as it requires authenthication to even use the packages, which means it's not usable for local work easily. Any chance we can publish this to a proper repo?

LightGuard commented 2 years ago

@pmuir what is going to be the easiest way for me to recreate your files so I can reproduce the error(s)?

LightGuard commented 2 years ago

Looks like cloning the repo and running npm --prefix .build run generate:modular-docs should be sufficient.

pmuir commented 2 years ago

Yes.

LightGuard commented 2 years ago

@pmuir would you mind building commit 40991ab and testing before I cut a dot release for this?

pmuir commented 2 years ago

That appears to work now.

LightGuard commented 2 years ago

I forgot how many hoops you had to go through to get stuff into central... sheeesh. At any rate:

<dependency>
  <groupId>io.github.lightguard.documentation</groupId>
  <artifactId>asciidoc-splitter</artifactId>
  <version>1.5.3</version>
  <classifier>bin</classifier>
  <type>zip</type>
</dependency>
<dependency>
  <groupId>io.github.lightguard.documentation</groupId>
  <artifactId>asciidoc-splitter</artifactId>
  <version>1.5.3</version>
  <classifier>bin</classifier>
  <type>tar.gz</type>
</dependency>
<dependency>
  <groupId>io.github.lightguard.documentation</groupId>
  <artifactId>asciidoc-splitter</artifactId>
  <version>1.5.3</version>
  <classifier>jar-with-dependencies</classifier>
</dependency>

Pick your poison, @pmuir.