search

LightTable / Clojure

Light Table Clojure language plugin
MIT License
99 stars 47 forks source link

Removed FS dependency #51

Closed tonsky closed 9 years ago

tonsky commented 9 years ago

lein-light-nrepl used to depend on fs library. This library is unstable (they change public API all too often), and is used in other projects (figwheel, lein-cljsbuild). It was a source of great pain (https://github.com/bhauman/lein-figwheel/issues/119, https://github.com/bhauman/lein-figwheel/issues/11, https://github.com/LightTable/LightTable/issues/1482, https://github.com/bhauman/devcards/issues/14).

Turned out it was not crucial to have this lib as a dependency. It was used rarely and for pretty trivial stuff. So I just removed it.

kenny-evitt commented 9 years ago

@cldwalker @rundis This looks reasonable; thoughts?

kenny-evitt commented 9 years ago

@tonsky Thanks for the changes

rundis commented 9 years ago

:+1: Nice to get rid of that pesky dependency regardless of whether we go down the route of inlining deps in the middleware or not.

cldwalker commented 9 years ago

Good eye @tonsky! Ideally we'd like to solve dependencies with a general solution like #48. But this seems reasonable in the meantime. Whomever merges please QA effected behaviors