search

LightTable / Clojure

Light Table Clojure language plugin
MIT License
99 stars 51 forks source link

Cleanup deps #53

Closed cldwalker closed 8 years ago

cldwalker commented 8 years ago

This PR updates tools.reader to a non-forked version, remove an unnecessary dependency on cheshire and cleans up some requires. QAed effected behavior. @LightTable/committers Feedback welcome. If I don't hear back I'll merge on monday/tuesday

cldwalker commented 8 years ago

@ibdknox I see ibdknox.analyzer was brought in with the initial commit at cljs "0.0-1934". Can you explain what cases it handled for the instarepl? I tried some basic mapping, reducing, fn defining and didn't see a difference between it and the current cljs version we have "0.0-2202"

ibdknox commented 8 years ago

I was trying to deal with dependency conflicts as I recall, but it was originally added because the analyzer didn't keep all the information I needed. I suspect it'd be fine to just use the cljs one now though.

cldwalker commented 8 years ago

@ibdknox Removed. Thanks for the quick feedback