search

LightTable / Clojure

Light Table Clojure language plugin
MIT License
99 stars 51 forks source link

Fix handler.cljs :require typo #92

Closed sbauer322 closed 7 years ago

sbauer322 commented 7 years ago

This PR fixes lighttable.nrepl.handler's :require as reported in issue #91. However, this does not resolve the actual problem. So, this PR is simply a typo fix.

sbauer322 commented 7 years ago

On November 12, 2016, I will be merging this pull request If no one responds or comments before then.

sbauer322 commented 7 years ago

This will be merged tomorrow @LightTable/maintainers

cldwalker commented 7 years ago

Happy to take this to get you more familiar with the codebase. In the future, I'd prefer we lay off refactor commits as there are higher priority issues. Fixing a typo here pulls on a thread about standardizing aliasing which we haven't had and isn't a high priority right now

sbauer322 commented 7 years ago

Sorry, I wasn't coming at this from a "lets find a refactoring task" standpoint but was the result of verifying https://github.com/LightTable/Clojure/issues/91 . As the change was implemented in order to determine if the issue was valid it made sense to simply throw up a PR.

I do agree we should largely stay away from refactoring tasks for the moment.

Happy to take this to get you more familiar with the codebase.

Could you clarify the above line - are you suggesting you want to take the issue and pursue the spec problem, merge the PR, or something else?

cldwalker commented 7 years ago

Could you clarify the above line - are you suggesting you want to take the issue and pursue the spec problem, merge the PR, or something else?

Good to merge :+1: