LightTable / Clojure

Light Table Clojure language plugin
MIT License
99 stars 51 forks source link

Add some docstrings to clojure.cljs and eval.clj namespaces #93

Closed sbauer322 closed 7 years ago

sbauer322 commented 7 years ago

This stems from @carocad's watch docstring PR, #89, as I found no clean way to append to his PR. The original will be closed.

The main difference is the usage of the :doc key for behaviors when a lot of information not suited for the :desc key occurred. The :doc key will officially be used for additional optional documentation once this Light Table PR is merged: https://github.com/LightTable/LightTable/pull/2276

There is also various minor formatting changes.

sbauer322 commented 7 years ago

On November 12, 2016, I will be merging this pull request If no one responds or comments before then.

It would be nice to have feedback to confirm everything is in order.

sbauer322 commented 7 years ago

Last call @LightTable/maintainers before this is merged!

cldwalker commented 7 years ago

Taking a look

sbauer322 commented 7 years ago

@cldwalker the requested changes have been addressed.

sbauer322 commented 7 years ago

Ready for you, @cldwalker!

cldwalker commented 7 years ago

Nice work! Let's ship it :+1: 🚢 :ocean: