search

LightTable / LightTable

The Light Table IDE ⛺
www.lighttable.com
MIT License
11.73k stars 918 forks source link

console errors when zooming in (on OS X) #1228

Closed killerswan closed 9 years ago

killerswan commented 10 years ago

ZOOM IN throws errors to console (but seems to work...):

Invalid behavior: :lt.objs.sidebar.command/exec-command
Error: Unable to convert 'args' passed to CallObjectMethodSync
    at Window.eval [as zoomLevel] (window_bindings.js:199:3)
    at Function.eval (file:///Applications/LightTable.app/Contents/Resources/app.nw/core/node_modules/lighttable/bootstrap.js:21255:36)
    at b (file:///Applications/LightTable.app/Contents/Resources/app.nw/core/node_modules/lighttable/bootstrap.js:6188:14)
    at a (file:///Applications/LightTable.app/Contents/Resources/app.nw/core/node_modules/lighttable/bootstrap.js:6234:18)
    at a (file:///Applications/LightTable.app/Contents/Resources/app.nw/core/node_modules/lighttable/bootstrap.js:21030:29)
    at b (file:///Applications/LightTable.app/Contents/Resources/app.nw/core/node_modules/lighttable/bootstrap.js:21034:14)
    at cljs.core.apply_to (file:///Applications/LightTable.app/Contents/Resources/app.nw/core/node_modules/lighttable/bootstrap.js:6097:85)
    at c (file:///Applications/LightTable.app/Contents/Resources/app.nw/core/node_modules/lighttable/bootstrap.js:6194:42)
    at a (file:///Applications/LightTable.app/Contents/Resources/app.nw/core/node_modules/lighttable/bootstrap.js:6236:18)
    at a (file:///Applications/LightTable.app/Contents/Resources/app.nw/core/node_modules/lighttable/bootstrap.js:25083:153)
rundis commented 10 years ago

tried with 0.6.3 on mac (maverick). Throws same exception, but no zoom (:

stoeckley commented 10 years ago

I second this (or third this). The window zoom command give ugly errors to the LT console.

MikeInnes commented 10 years ago

We are cleaning up LT's old issues and feature requests in batch so that things are more manageable. If your issue is still relevant to the latest version of LT, please let us know so we can re-open and take a look at it. Thanks!

Bost commented 9 years ago

The bug is relevant all the time even on the 2e4d3398f53cb6dc5dc54bb86a0782f3d1beab5
It comes from app.cljs: (set! (.-zoomLevel win) ...)

MikeInnes commented 9 years ago

Ok, I see this too, I'll reopen

Bost commented 9 years ago

See e.g. https://github.com/rogerwang/node-webkit/blob/master/src/api/bindings_common.cc#L157

Bost commented 9 years ago
cldwalker commented 9 years ago

Good to see its fixed upstream with rogerwang/node-webkit#1395 and rogerwang/node-webkit#1520. There isn't any LT-specific action to take here but will leave open until we upgrade node-webkit.

joshuafcole commented 9 years ago

This should be fixed in 0.7.0, and appears to be when I test it. Please comment if the issue still affects you on the new version.

Bost commented 9 years ago

??? There's no 0.7.0 tag yet. When do you want to release it?

joshuafcole commented 9 years ago

0.7.0 Just released today about an hour ago. Are you having trouble downloading/installing it?

On Wed, Nov 19, 2014 at 1:31 PM, Bost notifications@github.com wrote:

??? There's no 0.7.0 tag yet. When do you want to release it?

— Reply to this email directly or view it on GitHub https://github.com/LightTable/LightTable/issues/1228#issuecomment-63717443 .

Screw the environment. Please print this email immediately. And then burn it.

Bost commented 9 years ago

The 0.7.0 tag was missing. Chris fixed that ~1 sec ago :)

Bost commented 9 years ago

I tested the LightTableLinux64.tar.gz under the download link provided by lighttable.com. That works! Thx. However the problem persists when built from the source on linux using 'bash linux_build.sh'. It looks like (in generall) LT-development on linux... well it feels pretty lonely here :) Anyway I just rebased my own linux-build branch on top of the 0.7.0 but it doesn't help. As a consequence - please ignore my pull request #1467 until I find out what's wrong.

Bost commented 9 years ago

The upstream version of linux_build.sh has a major bug preventing this bug to go away when building LT using 'bash linux_build.sh'. The #1467 solves the problem (Yuhu :-). Please pull it or at least cherry-pick the 19c0917 from this PR. Apart from that I consider this bug to be fixed.