LightTable / Paredit

Light Table plugin for paredit ⛺
MIT License
35 stars 11 forks source link

Porting features from paredit-plus #18

Open cldwalker opened 10 years ago

cldwalker commented 10 years ago

This is a meta issue to port handy paredit functions from paredit-plus. We need to have one well-maintained plugin we can all rely on. Features that should be ported (list updated as needed):

I'll take this on unless @otijhuis is interested in helping with some of it (I know you're back in emacs land ;))

kenny-evitt commented 9 years ago

@cldwalker I could really use 'wrap'. Let me know when you could go over this with me; at least a push in the right direction.

cldwalker commented 9 years ago

@kenny-evitt Unfortunately I don't know any of this code base. If you just want wrap fns to use, paredit-plus has them. If you want to add to this plugin that's also great. We may also want to consider adopting @rundis' https://github.com/rundis/parembrace at some point @rundis Do you know what advantages and disadvantages parembrace has compared to this plugin?

rundis commented 9 years ago

From the top of my head;

Advantages in favour of parembrace

Disadvantages by using parembrace

@kenny-evitt I'm a little bit familiar with the code of this plugin, but really if we are to continue supporting a language neutral paredit, I think the code base needs a serious rewrite to make it maintainable. From a personal perspective I don't really work on any other lisps so I'm not interested in putting effort into this plugin, my time would be betters spent improving parembrace.

I'd be more than happy to hand over ownership of parembrace to LT :-)

kenny-evitt commented 9 years ago

@cldwalker No worries. I'll put working on this plugin onto the 'maybe' list then. I'm not sure what's responsible for the feature, but I can wrap a selection if I make a 'regular selection' – it's just the Vim selections (and, therefore, the Vim navigation features) that don't work.

@rundis I'll have to play with parembrace now too. I've got a list with several of your plugins on it to get thru eventually.

Maybe we should just canonize paredit-plus as the 'official' paredit plugin. There haven't been any updates in a while, but there aren't really any major open issues either.