search

Lightelligence / rules_verilog

Bazel build rules for compiling Verilog
Other
21 stars 7 forks source link

Should Internal .bzl files (inside verilog/private) have non-public visibility? #1

Closed wstucker closed 3 years ago

wstucker commented 3 years ago

CC @ciglass

ciglass commented 3 years ago

I briefly read through the bazel docs on visibility. Based on what I understand so far, using a visibility setting for .bzl files in verilog/private wouldn't have any functional impact right now.

visibility is used to control which packages have access to the targets in a BUILD file. The bazel docs say that load statements are not subject to visibility, which means we can't easily protect against loading from verilog/private:*.bzl intead of from verilog:defs.bzl.

@wstucker what do you think?

wstucker commented 3 years ago

We have a few places internally where we are still directly loading dv.bzl and rtl.bzl because we didn't expose all aspects and providers. I think this is fine for now. Lets just close this out and we can revisit if something prompts discussion again.