search

Lightelligence / rules_verilog

Bazel build rules for compiling Verilog
Other
18 stars 7 forks source link

fix the cov_opts issue that None type cannot be anded with the string opt… #41

Closed justin371 closed 1 year ago

justin371 commented 1 year ago

…ions

File "/nfs/workspace05/yyou/Aurora/bazel-bin/external/rules_verilog/bin/simmer.runfiles/rules_verilog/bin/simmer.py", line 1189, in pre_run cov_opts += ' -coverage {} '.format(options.coverage) TypeError: unsupported operand type(s) for +=: 'NoneType' and 'str'

jmlemay99 commented 1 year ago

Hi Lijie. I also found this issue while I was doing the simmer library work. It's part of my other PR that is just waiting for Cameron's approval. (I just changed the cov_opts default to an empty string.) Can we abandon this PR to avoid merge conflicts with mine?

justin371 commented 1 year ago

@jmlemay99 Sure, it's OK for me.