Lightman314 / LightmansCurrency

Lightman's Currency Minecraft Mod
Other
26 stars 16 forks source link

Feature Request: Config update for villager buy/sell values #204

Closed Br00t4L17y closed 6 months ago

Br00t4L17y commented 6 months ago

The problem: We'd like to be able to assign a different tier of coin required to buy items from a villager, than the tier of coin received from selling. On a server where we limit the speed at which you obtain coins (coin mint disabled), we don't want players accruing coins too fast.

Proposed solution: We'd like to make it so villagers sell items, say at T3 gold coin level. But then buy from the player at a T2 iron coin level. Being able to separate these values will help us fine tune the economy.

Lightman314 commented 6 months ago

I was already going to modify the villager item configs based on another feature request/suggestion from my discord, so I'll go ahead and add this in there when I add that :)

Br00t4L17y commented 6 months ago

Awesome, thank you for the quick response. I am looking forward to it!

Lightman314 commented 6 months ago

Appears to be working as intended: image Next build should be out soon, just need to do some more bug-testing before releasing it.

Br00t4L17y commented 6 months ago

Looks great! Will this be per trader? Or a global config option?

Lightman314 commented 6 months ago

It will be both. The default replacement coin input can now have two items defined (seperated by a ;, so a config option of "lightmanscurrency:coin_iron;lightmanscurrency:coin_copper" would result in the screenshotted results, and the villager overrides can have the same done to them as well (e.g. "minecraft:blacksmith-lightmanscurrency:coin_iron;lightmanscurrency:coin_copper", etc.)

This will now also be the default config value for the fletcher villager, buying items for copper coins but selling items to the players for iron coins, so you'll have an in-config example of how it's set up.

Br00t4L17y commented 6 months ago

Sounds perfect. Do you know when you will be releasing those changes?

Lightman314 commented 6 months ago

If everything goes well I'm hoping to have this out tomorrow for 1.20.1, and hopefully have it backported to 1.19.2 within a week or so.

Br00t4L17y commented 6 months ago

Exciting, thanks for the quick turn around on this feature

Lightman314 commented 6 months ago

Added in v2.2.1.1.