Lightman314 / LightmansCurrency

Lightman's Currency Minecraft Mod
Other
26 stars 16 forks source link

Feature Request: Allow Creative Traders to actually store coins paid by customers/send money paid to a linked bank account. #219

Closed QianMuu closed 4 months ago

QianMuu commented 4 months ago

Under normal circumstances, when you have a bank account and create a store, checking "Link to bank account" will deposit the coins directly into the bank account, which is correct. But when you check "Start creating transactions", then you will not get coins in your bank account. Is there a setting that allows "Start creating transactions" to obtain coins normally? ("Creating transactions" allows me not to replenish goods, but I want to get coins normally and deposit them into an account.)

Lightman314 commented 4 months ago

I'm afraid I'm very confused by your request as there is no "Start creating transations"/"Creating Transactions" checkmark, nor anything at all in my mod that uses that form of phrasing.

If you could clarify what you mean by that I'd appreciate it, but the "link to bank account" setting is perfectly independent of any other setting that exists on a trader (except for ownership, as changing the traders owner will disable the bank account link until the new owner re-enables it to avoid any form of fraud/exploits). If it's enabled the traders internal coin storage is disabled and all money earned and payed will come from and go to your bank account (or the teams bank account if owned by a team). If it's disabled, then all money earned and payed will come from and go to the traders personal money storage.

QianMuu commented 4 months ago

I'm afraid I'm very confused by your request as there is no "Start creating transations"/"Creating Transactions" checkmark, nor anything at all in my mod that uses that form of phrasing.

If you could clarify what you mean by that I'd appreciate it, but the "link to bank account" setting is perfectly independent of any other setting that exists on a trader (except for ownership, as changing the traders owner will disable the bank account link until the new owner re-enables it to avoid any form of fraud/exploits). If it's enabled the traders internal coin storage is disabled and all money earned and payed will come from and go to your bank account (or the teams bank account if owned by a team). If it's disabled, then all money earned and payed will come from and go to the traders personal money storage.

Yes, like you said, this is normal. I use "/lcadmin toggleadmin" to enter management mode and click "Disable Creative Trader" in the store's "Trader Settings", which will enter the creative trade. The store will enter a state where transactions can be carried out without replenishment, that’s what it is. But the coins obtained from the transaction will not go into the bank account (or the teams bank account). So, can there be an additional setting option to allow the "Creative Trader" mode to obtain coins normally, save them in the store or directly deposit them into a bank account (just like normal transactions) {071DCFB1-775B-4e84-9C7D-36B58CD21335}

Lightman314 commented 4 months ago

Since creative traders create the items sold from nothingness, they also take the money paid by the player and destroy it/send it to the void (and vice-versa if there's a purchase trade, the money paid to the player will be sourced from nothingness, and the items sold by the player will not go into the traders item storage, but be destroyed).

This is an intentional design feature as I don't want (potentially) corrupt admin players getting personal profit/monetary gain from a creative trader that they placed and/or claimed ownership of, etc. And I have no desire and/or wish to change this functionality of the creative mode, nor do I see any actual need or purpose of doing so, as any admin can simply create more money by grabbing coins from the creative menu, using the /give command, etc.

If you can give me an actual beneficial use of having creative traders actually store the money/items earned from trades, I'm all ears, but I see no actual beneficial use for admins being able to gain money from creative traders other than admin abuse/corruption.

QianMuu commented 4 months ago

Since creative traders create the items sold from nothingness, they also take the money paid by the player and destroy it/send it to the void (and vice-versa if there's a purchase trade, the money paid to the player will be sourced from nothingness, and the items sold by the player will not go into the traders item storage, but be destroyed).

This is an intentional design feature as I don't want (potentially) corrupt admin players getting personal profit/monetary gain from a creative trader that they placed and/or claimed ownership of, etc. And I have no desire and/or wish to change this functionality of the creative mode, nor do I see any actual need or purpose of doing so, as any admin can simply create more money by grabbing coins from the creative menu, using the /give command, etc.

If you can give me an actual beneficial use of having creative traders actually store the money/items earned from trades, I'm all ears, but I see no actual beneficial use for admins being able to gain money from creative traders other than admin abuse/corruption.

Is there a way to connect all stores in one area? For example, connecting "display_case" and "card_display_oak_white" within an area to achieve automatic replenishment? If a player builds a large store, going to each store to restock one by one would be a waste of time. Creating a device to gather all items together and achieve automatic restocking in each store. Or? The current version has already implemented this method, so how will I implement it?

(As you said, I also dislike using cheating to obtain coins, but if the coins are obtained through trading, they can be stored in a certain account. When a certain amount is reached, all players on the server will receive rewards, like milestones.)

Lightman314 commented 4 months ago

It sounds to me like the more feasible change/addition to meet your intentions would be to have the traders store stats on money earned, and possibly even have those stats be passed on to the team if owned by a team (where it'll have a stat with the total money earned by all traders that team owns, etc.).

That should give you the data you want far easier than reworking/redesigning how creative traders work, etc. and it shouldn't be too hard to add as I already have a similar system in place for the tax collectors.

QianMuu commented 4 months ago

在我看来,更可行的改变/增加,以满足您的意图将是让交易者存储赚钱的统计数据,甚至可能将这些统计数据传递给团队,如果由团队拥有的话(其中它将有一个统计数据,其中包含团队拥有的所有交易者的总收入等)。

这应该给予你想要的数据远比重新工作/重新设计创造性交易者的工作方式容易得多,而且它不应该太难添加,因为我已经有一个类似的系统在地方的税务人员。

Thank you, looking forward to your update.