search

Lightman314 / LightmansCurrency

Lightman's Currency Minecraft Mod
Other
26 stars 16 forks source link

Adds some new minor QoL features to the Network Terminal Screen #227

Closed sesgoe closed 3 months ago

sesgoe commented 3 months ago

Adds a new checkbox to the NetworkTerminalScreen that lets you hide empty traders from being viewable, and also add a singleton to maintain the NetworkTerminalScreen state in between screen loads.

When you're clicking in and out of traders' wares, it's frustrating to constantly have to re-search for whatever you were looking for. With a singleton, this state is maintained for the duration that minecraft is running. It will reset whenever you reload the game, which seems reasonable here.

Here are some screenshots detailing the changes:

image Here's a look at the new checkbox, unchecked to show that it just does whatever it did before if it's unchecked. No loss of behavior.

image When you open the screen initially, the search is blank, and the checkbox is set to true. The new tooltips are an excellent addition, but I still found it pretty cumbersome to mouseover all the empty trading stations (especially those where people craft one, plonk it down, and then never look at it again).

The other feature I added was to put the NetworkTerminalScreen state into a singleton so that the state is preserved between GUI loads and unloads. This means when you search for whatever you're looking for, you can happily keep clicking back and forth between trades and the individual traders while searching for your specific item.

Here's a 10-second clip of me clicking through it and showing that state is now preserved. https://github.com/Lightman314/LightmansCurrency/assets/5777539/4b22920d-416f-4947-9da4-6e798c2b8249

This is my first ever foray into Minecraft modding, so I apologize for any glaring errors or mistakes I have likely made here -- I tried to keep this pretty minimal so it would be easy to review and merge, but there are a few decisions I have made, and I will detail them in PR comments on the code below so they're easier to understand with surrounding context.

I adore your mod, and I hope you'll consider making these small changes to improve players' quality of life while using it. 😄

Lightman314 commented 3 months ago

Please fill out a Feature Request, this is not the place for requesting a QoL change.

I am more than capable of implementing such a thing on my own thank you very much, and the way you've implemented many of these changes will break many of the other trader types (such as the auction house). While I'm certainly not against these changes themselves (or at least what little I've seen), they should be properly discussed in the aforementioned Feature Request first before I will take any action on them. Especially since this pull request won't be able to be merged with the code I have in my dev environment as it's heavily changed many screens in my mod, as I'm in the process of reworking many aspects of my mod.