Lightmatter / welkin-health

A Python wrapper of the Welkin Health API
https://welkin.readthedocs.io
Other
4 stars 3 forks source link

Bug/formations mishandle args kwargs #41

Closed edcohen08 closed 2 years ago

edcohen08 commented 2 years ago

Adds args and kwargs to the Formations get

codecov[bot] commented 2 years ago

Codecov Report

Base: 94.55% // Head: 94.71% // Increases project coverage by +0.16% :tada:

Coverage data is based on head (a0de301) compared to base (acf9abd). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #41 +/- ## =========================================== + Coverage 94.55% 94.71% +0.16% =========================================== Files 29 31 +2 Lines 1340 1381 +41 =========================================== + Hits 1267 1308 +41 Misses 73 73 ``` | [Impacted Files](https://codecov.io/gh/Lightmatter/welkin-health/pull/41?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Lightmatter) | Coverage Δ | | |---|---|---| | [test/test\_formations.py](https://codecov.io/gh/Lightmatter/welkin-health/pull/41/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Lightmatter#diff-dGVzdC90ZXN0X2Zvcm1hdGlvbnMucHk=) | `100.00% <100.00%> (ø)` | | | [welkin/client.py](https://codecov.io/gh/Lightmatter/welkin-health/pull/41/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Lightmatter#diff-d2Vsa2luL2NsaWVudC5weQ==) | `91.00% <100.00%> (+0.37%)` | :arrow_up: | | [welkin/models/\_\_init\_\_.py](https://codecov.io/gh/Lightmatter/welkin-health/pull/41/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Lightmatter#diff-d2Vsa2luL21vZGVscy9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | [welkin/models/formation.py](https://codecov.io/gh/Lightmatter/welkin-health/pull/41/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Lightmatter#diff-d2Vsa2luL21vZGVscy9mb3JtYXRpb24ucHk=) | `100.00% <100.00%> (ø)` | | | [welkin/pagination.py](https://codecov.io/gh/Lightmatter/welkin-health/pull/41/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Lightmatter#diff-d2Vsa2luL3BhZ2luYXRpb24ucHk=) | `94.94% <100.00%> (+0.69%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Lightmatter). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Lightmatter)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.