Fishing line is always rendered at full brightness

[DmitriBogdanov]

Version

Minecraft: 1.20.1 Fabric: 0.16.5 Mod: 1.3.1

Issue

The fishing line is always rendered at full brightness without respecting the light level.

While it looks fine during the day, at night the bright texture really stands out from its surrounding, especially when using shaders.

Screenshots

Without shaders, default fishing line:

With shaders, default fishing line:

With shaders, golden fishing line:

If rendering fishing line with proper brightness is technically difficult, it might be easier to just leave a "render vanilla fishing line" option in the config.

[Lightning-64]

Dynamic fishing line brightness is something I have experimented with because I've noticed this too, even without shaders. It is especially jarring sometimes underground.

In my tests I've found proper brightness to be very buggy, but this is a feature I would love to add, so I will definitely try again to make sure this is properly implemented. If I can't get it to work, I'll just add a config setting to render the default black line.

[Lightning-64]

A config setting to use the default black fishing line is added as of 1.3.2! I will try to add proper brightness in the future, but I'm closing this issue for now.