codecov[bot]
commented
2 months ago Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 95%. Comparing base (
1e7140d) to head (5e62946). Report is 1 commits behind head on main.
Before submitting
- [ ] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements) - [ ] Did you read the [contributor guideline](https://github.com/Lightning-AI/pytorch-lightning/blob/main/.github/CONTRIBUTING.md), Pull Request section? - [ ] Did you make sure to update the docs? - [ ] Did you write any new necessary tests?⚠️ How does this PR impact the user? ⚠️
Avoid
uvloopnot installed warning by automatic installation on supported system.GOOD:
"As a user, I need to serve models faster. This PR focuses on enabling speed gains by using GPUs"
BAD:
"This PR enables GPUs". This is bad because the user problem is not clear... instead it just jumps to the solution without any context.
PRs without this will not be merged.
What does this PR do?
uvloop is a faster drop-in replacement of asyncio loop and we used it during all our benchmarks. It should be shipped along with the package on supported systems.
uvcorn[standard]installs uvloop.PR review
Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃