search

Lightning-AI / LitServe

Lightning-fast serving engine for any AI model of any size. Flexible. Easy. Enterprise-scale.
https://lightning.ai/docs/litserve
Apache License 2.0
2.5k stars 158 forks source link

[Chore] rename setup_server to register_endpoints #281

Closed aniketmaurya closed 2 months ago

aniketmaurya commented 2 months ago
Before submitting - [ ] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements) - [ ] Did you read the [contributor guideline](https://github.com/Lightning-AI/pytorch-lightning/blob/main/.github/CONTRIBUTING.md), Pull Request section? - [ ] Did you make sure to update the docs? - [ ] Did you write any new necessary tests?

⚠️ How does this PR impact the user? ⚠️

No impact. It's a code readability update.

What does this PR do?

Rename LitServer.setup_servers to register_endpoints which explains the work of this method.

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@676a560). Learn more about missing BASE report. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #281 +/- ## ===================================== Coverage ? 95% ===================================== Files ? 14 Lines ? 1076 Branches ? 0 ===================================== Hits ? 1019 Misses ? 57 Partials ? 0 ```