search

Lightning-AI / LitServe

Lightning-fast serving engine for any AI model of any size. Flexible. Easy. Enterprise-scale.
https://lightning.ai/docs/litserve
Apache License 2.0
2.51k stars 160 forks source link

Enable gpu docker image generation #311

Closed aniketmaurya closed 1 month ago

aniketmaurya commented 1 month ago
Before submitting - [ ] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements) - [ ] Did you read the [contributor guideline](https://github.com/Lightning-AI/pytorch-lightning/blob/main/.github/CONTRIBUTING.md), Pull Request section? - [ ] Did you make sure to update the docs? - [ ] Did you write any new necessary tests?

What does this PR do?

Follow up of #298, generate GPU based Dockerfile by providing the --gpu argument from CLI.

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95%. Comparing base (6b1ccc7) to head (6fcdd78). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #311 +/- ## =================================== Coverage 95% 95% =================================== Files 21 21 Lines 1310 1316 +6 =================================== + Hits 1239 1245 +6 Misses 71 71 ```
aniketmaurya commented 1 month ago

Looks good but I think could benefit from some examples - I was able to get something working but took a few iterations :)

@ethanwharris I am enhancing the description for the CLI. Could you please specify and share about your experience and what kind of example would you expect?