search

Lightning-AI / LitServe

Lightning-fast serving engine for any AI model of any size. Flexible. Easy. Enterprise-scale.
https://lightning.ai/docs/litserve
Apache License 2.0
2.5k stars 158 forks source link

Pyright linting fixes #314

Closed grumpyp closed 1 month ago

grumpyp commented 1 month ago
Before submitting - [x] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements) - [x] Did you read the [contributor guideline](https://github.com/Lightning-AI/pytorch-lightning/blob/main/.github/CONTRIBUTING.md), Pull Request section? - [x] Did you make sure to update the docs? - [x] Did you write any new necessary tests? I didn't. After the test pipeline ran, I'll fix tests if needed.

What does this PR do?

User won't see Pyright issues if copying the example from the README. No confusion,..

Fixes #310 .

PR review

Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

grumpyp commented 1 month ago

image

as reference I attached the screenshot. the devices -> device renaming will be fixed with this PR.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95%. Comparing base (6e9dca6) to head (30ae246). Report is 11 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #314 +/- ## =================================== - Coverage 95% 95% -0% =================================== Files 19 21 +2 Lines 1244 1316 +72 =================================== + Hits 1182 1245 +63 - Misses 62 71 +9 ```