Closed AlexShukhman closed 6 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 94%. Comparing base (
c8cf6b2
) to head (0aff598
). Report is 1 commits behind head on main.
🚨 Try these New Features:
Before submitting
- [ ] Was this discussed/agreed via a Github issue? (no need for typos and docs improvements) (N/A: Typo-ish) - [x] Did you read the [contributor guideline](https://github.com/Lightning-AI/pytorch-lightning/blob/main/.github/CONTRIBUTING.md), Pull Request section? - [ ] Did you make sure to update the docs? (N/A) - [x] Did you write any new necessary tests?This prevents an issue for users of the
dockerize
command-line argument where they can't complete the builds of their containers without updating the base image.What does this PR do?
Fixes the containerization feature of LitServe, allowing users to use LitServe to containerize without having to update the base image.
https://www.loom.com/share/4cd25d16e6a745269d989ec7ba167274?sid=81833ec0-2d88-462e-8eba-85252dfaf237
PR review
Anyone in the community is free to review the PR once the tests have passed. If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Make sure you had fun coding 🙃