prune seed - Githubissues

Lightning-AI / deep-learning-project-template

Pytorch Lightning code guideline for conferences

Apache License 2.0

1.23k stars 269 forks source link

prune seed #10

Closed Borda closed 4 years ago

Borda commented 4 years ago

remove production_mnist as it the same as research_mnist just using a deprecated dictionary on the __step_end

some next steps/PRs

add testing
generating docs

pretty much adding CI/docs tools as we have in Sandbox

pep8speaks commented 4 years ago

Hello @Borda! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file setup.py:

Line 10:80: E501 line too long (127 > 79 characters)

Comment last updated at 2020-08-28 13:55:34 UTC

Borda commented 4 years ago

before #9 it was almost duplicated, then #9 updated just research part and left production_mnist outdated I was asking @williamFalcon and he agreed with this pruning... :]