adding minimal CI - Githubissues

Lightning-AI / deep-learning-project-template

Pytorch Lightning code guideline for conferences

Apache License 2.0

1.23k stars 269 forks source link

adding minimal CI #15

Closed Borda closed 4 years ago

Borda commented 4 years ago

adding minimal CI testing

pep8speaks commented 4 years ago

Hello @Borda! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

In the file setup.py:

Line 16:1: W391 blank line at end of file

Comment last updated at 2020-09-11 17:45:50 UTC

Borda commented 4 years ago

@williamFalcon seems you miss adding module with MNIST, mind add it?

Borda commented 4 years ago

@oke-aditya mind help you...

oke-aditya commented 4 years ago

Very nice. I Just had a doubt. Since this code has a setup.py file. Do we need pip install -e . in CI which will install this codebase and run tests?

Borda commented 4 years ago

For testing you don't need to install the package itself, just all needed dependences...