search

Lightning-AI / deep-learning-project-template

Pytorch Lightning code guideline for conferences
Apache License 2.0
1.23k stars 269 forks source link

CI continously failing #18

Open pierresegonne opened 3 years ago

pierresegonne commented 3 years ago

Problem

The template test test_classifier.py does not pass when triggered as a GitHub action.

The issue comes from imports. Indeed the import from project.datasets.mnist import mnist is erroneous. There is no datasets folder in project because datasets is ignored (see l.37 of .gitignore).

Pulling the MNIST dataset everytime the GitHub action is triggered does not seem reasonable. My proposal would be to have a samples_datasets/ subfolder in test, not ignored, with a limited number of data points, and to use that for testing.

If anyone agree that it's a reasonable way to go, I'll create a PR :)

Borda commented 3 years ago

yes, some files are missing, probably @williamFalcon has them locally,,,